Trixie pimodbus-client BUG (with Fix)

Topics about the Software of Revolution Pi
Post Reply
User avatar
RR4711
Posts: 247
Joined: 22 Feb 2018, 13:28

Trixie pimodbus-client BUG (with Fix)

Post by RR4711 »

Hi,
I'm in Brazil right now and didn't have time to test the trixie beta with our application and the trixie final was released basically when I was in the Airplane to Brazil.

I'm here converting an older system using the MODBUS RTU Server (back then it was still called properly).

After installing the trixie system the pimodbus-client service always bailes out with:
No modbus actions for device
After long debugging, digging through the .rsc JSON and the pimodbus-client sources, it turns out there is a JSON tag named wrong in the piConfigParser.c, presumably it got falsely renamed in the master/server/client/slave renaming spree.

This leads to the parser skipping out of the iteration loop, and subsequently to an empty action item list, which causes the bailout.
I made a pull request here:
https://github.com/RevolutionPi/revpi-modbus/pull/49

Can someone please test with MODBUS TCP since I have no devices here and if it works please merge and build an updated package?

Cheers,
Markus
User avatar
nicolaiB
KUNBUS
Posts: 1134
Joined: 21 Jun 2018, 10:33
Location: Berlin
Contact:

Re: Trixie pimodbus-client BUG (with Fix)

Post by nicolaiB »

(copied from my GitHub response):

Hi Markus, that for reporting this. We will have a look and publish an update once this is fixed.

btw. your repositories have been moved to GitLab some years ago, so GitHub is only the mirror for keeping the presence. New new link for modbus is https://gitlab.com/revolutionpi/revpi-modbus
Nicolai
Roelof
Posts: 3
Joined: 19 Jun 2024, 15:38

Re: Trixie pimodbus-client BUG (with Fix)

Post by Roelof »

Is there a work around for the time being? Or should I do a downgrade to bookworm?
Roelof
Posts: 3
Joined: 19 Jun 2024, 15:38

Re: Trixie pimodbus-client BUG (with Fix)

Post by Roelof »

I found the workaround. Replace SlaveAddress by ServerAddress in de config file:

Code: Select all

sudo sed -i 's/SlaveAddress/ServerAddress/g' /etc/revpi/config.rsc
User avatar
RevPiModIO
KUNBUS
Posts: 376
Joined: 20 Jan 2017, 08:44
Contact:

Re: Trixie pimodbus-client BUG (with Fix)

Post by RevPiModIO »

We have released an update that fixes the error. Please update according to the instructions and be sure to create a new PiCtory configuration!

Update: https://revolutionpi.com/en/docs/updates

Sven
python3-RevPiModIO - https://revpimodio.org/ || Der RevPi ist das Beste, was passieren konnte!
Post Reply